Replace usages of Map.Insert* #13736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
djaglowski,
jmacd,
dashpole and
Aneurysm9
as code owners
dmitryax
requested review from
TylerHelmuth,
bogdandrutu,
jpkrohling and
mx-psi
as code owners
This change replaces usages on Map.Insert* with Map.Upsert* where there is no data under the key. This covers only part of the usages. More changes will be added in next PRs
dmitryax
force-pushed
the
dont-use-insert
branch
from
a726f93 to
2ad6830
Compare
bogdandrutu
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces usages on
Map.Insert*withMap.Upsert*where there is no data expected under the key. This is done to evaluate open-telemetry/opentelemetry-collector#5998. We want to see how many places we have that really require usingInsertmethods.This covers only part of the usages. More changes will be added in next PRs